netdev - Re: [PATCH net-next] net: fix net device address assign type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 22 Jun 2023 08:37:10 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Piotr Gardocki <piotrx.gardocki@...el.com>
Cc: netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
	przemyslaw.kitszel@...el.com, michal.swiatkowski@...ux.intel.com,
	pmenzel@...gen.mpg.de, kuba@...nel.org,
	maciej.fijalkowski@...el.com, anthony.l.nguyen@...el.com,
	aleksander.lobakin@...el.com, gal@...dia.com
Subject: Re: [PATCH net-next] net: fix net device address assign type

On Wed, Jun 21, 2023 at 03:21:06PM +0200, Piotr Gardocki wrote:
> Commit ad72c4a06acc introduced optimization to return from function
> quickly if the MAC address is not changing at all. It was reported
> that such change causes dev->addr_assign_type to not change
> to NET_ADDR_SET from _PERM or _RANDOM.
> Restore the old behavior and skip only call to ndo_set_mac_address.
> 
> Fixes: ad72c4a06acc ("net: add check for current MAC address in dev_set_mac_address")
> Reported-by: Gal Pressman <gal@...dia.com>
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@...el.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>