netdev - Re: [net-next 14/15] net/mlx5: Light probe local SFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJPsTVKUj/hCUozU@nanopsycho>
Date: Thu, 22 Jun 2023 08:38:05 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Saeed Mahameed <saeed@...nel.org>, Saeed Mahameed <saeedm@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Tariq Toukan <tariqt@...dia.com>,
	Shay Drory <shayd@...dia.com>, Moshe Shemesh <moshe@...dia.com>
Subject: Re: [net-next 14/15] net/mlx5: Light probe local SFs

Wed, Jun 21, 2023 at 03:14:35PM CEST, jiri@...nulli.us wrote:
>Thu, Jun 15, 2023 at 09:33:25PM CEST, kuba@...nel.org wrote:
>>On Thu, 15 Jun 2023 19:37:23 +0200 Jiri Pirko wrote:
>>> Thu, Jun 15, 2023 at 06:37:01PM CEST, kuba@...nel.org wrote:
>>> >On Thu, 15 Jun 2023 12:51:09 +0200 Jiri Pirko wrote:  

[...]

>>As a reminder what sparked this convo is that user specifies "sfnum 11"
>>in the example, and the sf device gets called "sf.1".
>
>Yeah, will look into that as well.

I checked, the misalignment between sfnum and auxdev index.
The problem is that the index space of sfnum is per-devlink instance,
however the index space of auxdev is per module name.
So if you have one devlink instance managing eswitch, in theory we can
map sfnum to auxdev id 1:1. But if you plug-in another physical nic,
second devlink instance managing eswitch appears, then we have an
overlap. I don't see any way out of this, do you?

But, I believe if we add a proper reference between devlink sf port and
the actual sf devlink instace, that would be enough.