netdev - Re: [PATCH net] net: txgbe: change hw reset mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230622192158.50da604e@kernel.org>
Date: Thu, 22 Jun 2023 19:21:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, mengyuanlou@...-swift.com
Subject: Re: [PATCH net] net: txgbe: change hw reset mode

On Wed, 21 Jun 2023 17:06:45 +0800 Jiawen Wu wrote:
> The old way to do hardware reset is sending reset command to firmware.
> In order to adapt to the new firmware, driver directly write register
> of LAN reset instead of the old way.

Which versions of the FW use one method vs the other? Why is it okay 
to change the driver for new FW, are there no devices running old FW
in the wild? Or the new method is safe for both?

We need more information, we had a number of reports recently about
drivers breaking backwards compatibility and causing regressions for
users.

> And remove the redundant functions
> wx_reset_hostif() and wx_calculate_checksum().

You don't have to say that, it's a natural part of the change.
-- 
pw-bot: cr