netdev - Re: [PATCH net] net: txgbe: change hw reset mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D61A4E6D-8049-4454-9870-E62C2A980D0C@net-swift.com>
Date: Sun, 25 Jun 2023 16:31:01 +0800
From: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jiawen Wu <jiawenwu@...stnetic.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] net: txgbe: change hw reset mode



> 2023年6月23日 10:21，Jakub Kicinski <kuba@...nel.org> 写道：
> 
> On Wed, 21 Jun 2023 17:06:45 +0800 Jiawen Wu wrote:
>> The old way to do hardware reset is sending reset command to firmware.
>> In order to adapt to the new firmware, driver directly write register
>> of LAN reset instead of the old way.
> 
> Which versions of the FW use one method vs the other? Why is it okay 
> to change the driver for new FW, are there no devices running old FW
> in the wild? Or the new method is safe for both?

Lan reset contains of phy reset and dma reset.
New FW versions will support NCSI/LLDP which needs phy not to down.
When drivers do lan reset, fw can set a veto bit to block phy reset and
still to do dma reset.

> 
> We need more information, we had a number of reports recently about
> drivers breaking backwards compatibility and causing regressions for
> users.
> 
>> And remove the redundant functions
>> wx_reset_hostif() and wx_calculate_checksum().
> 
> You don't have to say that, it's a natural part of the change.
> -- 
> pw-bot: cr
> 
>