netdev - Re: [RFC PATCH v2 1/4] net: wire up support for file_operations->uring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c6dc00b-9e25-501f-1497-ce7f67694a0e@kernel.org>
Date: Fri, 23 Jun 2023 08:20:25 -0700
From: David Ahern <dsahern@...nel.org>
To: Stefan Metzmacher <metze@...ba.org>, Breno Leitao <leitao@...ian.org>,
 axboe@...nel.dk, asml.silence@...il.com
Cc: io-uring@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com,
 Matthieu Baerts <matthieu.baerts@...sares.net>,
 Mat Martineau <martineau@...nel.org>,
 Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
 Xin Long <lucien.xin@...il.com>, leit@...com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, dccp@...r.kernel.org, mptcp@...ts.linux.dev,
 linux-sctp@...r.kernel.org, ast@...nel.org, kuniyu@...zon.com,
 martin.lau@...nel.org, Jason Xing <kernelxing@...cent.com>,
 Joanne Koong <joannelkoong@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Jason A. Donenfeld" <Jason@...c4.com>, Willem de Bruijn
 <willemb@...gle.com>, Guillaume Nault <gnault@...hat.com>,
 Andrea Righi <andrea.righi@...onical.com>
Subject: Re: [RFC PATCH v2 1/4] net: wire up support for
 file_operations->uring_cmd()

On 6/23/23 3:17 AM, Stefan Metzmacher wrote:
> 
> I'd like to keep it passed to socket layer, so that sockets could
> implement some extra features in an async fashion.
> 
> What about having the function you posted below (and in v3)
> as a default implementation if proto_ops->uring_cmd is NULL?
> 

Nothing about this set needs uring_cmd added to proto ops. It adds uring
commands which are wrappers to networking APIs. Let's keep proper APIs
between subsystems.