netdev - Re: After kernel 6.3.7 or 6.3.8 b43 driver fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d33a248c-c7ac-43d3-b602-3c801d697922@app.fastmail.com>
Date: Sat, 24 Jun 2023 11:29:56 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: Michael Büsch <m@...s.ch>,
 "Bagas Sanjaya" <bagasdotme@...il.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
 "Linux Regressions" <regressions@...ts.linux.dev>,
 "Linux Wireless" <linux-wireless@...r.kernel.org>,
 Netdev <netdev@...r.kernel.org>, "kernel test robot" <lkp@...el.com>,
 "Simon Horman" <simon.horman@...igine.com>,
 "Larry Finger" <Larry.Finger@...inger.net>, "Kalle Valo" <kvalo@...nel.org>,
 sardonimous@...mail.com
Subject: Re: After kernel 6.3.7 or 6.3.8 b43 driver fails

On Sat, Jun 24, 2023, at 10:50, Michael Büsch wrote:
> On Sat, 24 Jun 2023 08:44:15 +0700
> Bagas Sanjaya <bagasdotme@...il.com> wrote:
>> > I suspect change introduced when addressing a compiler warning
>> > cased the error.
>> > 
>> > https://patchwork.kernel.org/project/linux-wireless/patch/20230516183442.536589-1-arnd%40kernel.org/
>
>
> I doubt it.
> This patch affects the device initialization code. But the crash is in
> the transmit path.
> Can you please double check by manually reverting the patch?

I'm travelling at the moment and can't easily check it, but I would
expect that my patch has no effect on the generated object code at
all. If the compiler output is different with and without my patch,
it's probably wrong. I double-checked the structure layout in
https://godbolt.org, this did not produce any changes, as size,
alignement and offsets of the members are all the same.

     Arnd