netdev - Re: [PATCH net v3] net: lan743x: Don't sleep in atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFyOScpRDOvVrCsrwdxFstoNf1tOEnGbPSt5XDM1PKhCDyUGaw@mail.gmail.com>
Date: Tue, 27 Jun 2023 15:40:04 +0200
From: Moritz Fischer <moritzf@...gle.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Maciej Fijalkowski <maciej.fijalkowski@...el.com>, netdev@...r.kernel.org, pabeni@...hat.com, 
	kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net, 
	bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com, mdf@...nel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH net v3] net: lan743x: Don't sleep in atomic context

Hi Andrew,

On Tue, Jun 27, 2023 at 3:07 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > > +static int lan743x_csr_wait_for_bit_atomic(struct lan743x_adapter *adapter,
> >
> > adapter is not used in readx_poll_timeout_atomic() call, right?
> > can be removed.
>
> I thought that when i first looked at an earlier version of this
> patch. But LAN743X_CSR_READ_OP is not what you think :-(

Yeah, it's not great / confusing. I tried to keep it the same as the
rest of the file when fixing the bug.

I can see if I can clean it up across the file in a follow up.
>
>        Andrew

Do you want me to send a v4 with an updated commit message?

Thanks,
Moritz