netdev - Re: [PATCH net] net: txgbe: change hw reset mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 27 Jun 2023 10:18:46 +0800
From: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>,
 Jiawen Wu <jiawenwu@...stnetic.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] net: txgbe: change hw reset mode

> 2023年6月27日 01:24，Jakub Kicinski <kuba@...nel.org> 写道：
> 
> On Mon, 26 Jun 2023 09:56:32 +0800 mengyuanlou@...-swift.com wrote:
>>> That does not answer the question. Is this backwards compatible with
>>> old firmware?  
>> 
>> Yeah，the veto bit is not set in old firmware, so they have the same effect.
> 
> Why were you using the more complex FW command then rather than just 
> the register write, previously then?
> 

Using FW command can notify fw that lan reset has happened, then FW
can configure something which should reconfigure.

Drivers write the register, the FW will not know lan reset has happened.

Later, we found the things which FW need in NCSI/LLDP/WOL... is only the phy. 
So just block phy reset, and use simple the register write.