netdev - Re: [PATCH net] net: txgbe: change hw reset mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230626202844.346de86b@kernel.org>
Date: Mon, 26 Jun 2023 20:28:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
Cc: Andrew Lunn <andrew@...n.ch>, Jiawen Wu <jiawenwu@...stnetic.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] net: txgbe: change hw reset mode

On Tue, 27 Jun 2023 10:18:46 +0800 mengyuanlou@...-swift.com wrote:
> > Why were you using the more complex FW command then rather than just 
> > the register write, previously then?
> 
> Using FW command can notify fw that lan reset has happened, then FW
> can configure something which should reconfigure.

This sentence is not entirely clear to me.

> Drivers write the register, the FW will not know lan reset has happened.
> 
> Later, we found the things which FW need in NCSI/LLDP/WOL... is only the phy. 
> So just block phy reset, and use simple the register write.

Fair enough, please include the explanation of backward compatibility
in the commit message and post a v2.