netdev - Re: [PATCH net] tcp: annotate data races in __tcp_oow_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJ3Z3jBp98dbFG3k@corigine.com>
Date:   Thu, 29 Jun 2023 21:22:06 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        eric.dumazet@...il.com
Subject: Re: [PATCH net] tcp: annotate data races in __tcp_oow_rate_limited()

On Thu, Jun 29, 2023 at 04:41:50PM +0000, Eric Dumazet wrote:
> request sockets are lockless, __tcp_oow_rate_limited() could be called
> on the same object from different cpus. This is harmless.
> 
> Add READ_ONCE()/WRITE_ONCE() annotations to avoid a KCSAN report.
> 
> Fixes: 4ce7e93cb3fe ("tcp: rate limit ACK sent by SYN_RECV request sockets")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>