netdev - RE: [PATCH net] nfp: clean mc addresses in application firmware when driver exits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR13MB3705404F697F02EA464D4C78FC2AA@DM6PR13MB3705.namprd13.prod.outlook.com>
Date: Fri, 30 Jun 2023 04:43:05 +0000
From: Yinjun Zhang <yinjun.zhang@...igine.com>
To: Jacob Keller <jacob.e.keller@...el.com>, Louis Peens
	<louis.peens@...igine.com>, David Miller <davem@...emloft.net>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Simon Horman <simon.horman@...igine.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "stable@...r.kernel.org" <stable@...r.kernel.org>,
	oss-drivers <oss-drivers@...igine.com>
Subject: RE: [PATCH net] nfp: clean mc addresses in application firmware when
 driver exits

On Thursday, June 29, 2023 2:21 AM, Jacob Keller wrote:
> 
> Is there no way to just ask the kernel what addresses you already have
> and avoid the need for a separate copy maintained in the driver? Or
> maybe thats something that could be added since this doesn't seem like a
> unique problem.
> 
> In fact, we absolutely can:
> 
> __dev_mc_unsync which is the opposite of __dev_mc_sync.
> 
> You can just call that during tear down with an unsync function and you
> shouldn't need to bother maintaining your own list at all.

Yes, you're right, I'll use _unsync. Thank you.

> 
> >       nfp_net_reconfig_wait_posted(nn);
> >  }