netdev - RE: [PATCH net] nfp: clean mc addresses in application firmware when driver exits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR13MB37058006B5841153E6B95E59FC2AA@DM6PR13MB3705.namprd13.prod.outlook.com>
Date: Fri, 30 Jun 2023 04:49:39 +0000
From: Yinjun Zhang <yinjun.zhang@...igine.com>
To: Jakub Kicinski <kuba@...nel.org>, Louis Peens <louis.peens@...igine.com>
CC: David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <simon.horman@...igine.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "stable@...r.kernel.org" <stable@...r.kernel.org>,
	oss-drivers <oss-drivers@...igine.com>
Subject: RE: [PATCH net] nfp: clean mc addresses in application firmware when
 driver exits

On Thursday, June 29, 2023 4:59 AM, Jakub Kicinski wrote:
> On Wed, 28 Jun 2023 11:32:28 +0200 Louis Peens wrote:
> > The configured mc addresses are not removed from application firmware
> > when driver exits. This will cause resource leak when repeatedly
> > creating and destroying VFs.
> 
> I think the justification is somewhat questionable, too.
> VF is by definition not trusted. Does FLR not clean up the resources?

Sorry, it doesn't. And I also find that moving netdev from one namespace
to another causes the same problem. So this fix is not for the VF case only.