netdev - Re: [PATCH net] mlxsw: spectrum_router: Fix an IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2902e638-0d4c-7ca8-6ca0-9d1ba752a20c@intel.com>
Date: Mon, 3 Jul 2023 17:41:50 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Petr Machata <petrm@...dia.com>, Ido Schimmel <idosch@...dia.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Danielle Ratson
	<danieller@...dia.com>, <netdev@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net] mlxsw: spectrum_router: Fix an IS_ERR() vs NULL check

From: Dan Carpenter <dan.carpenter@...aro.org>
Date: Mon, 3 Jul 2023 18:24:52 +0300

> The mlxsw_sp_crif_alloc() function returns NULL on error.  It doesn't
> return error pointers.  Fix the check.
> 
> Fixes: 78126cfd5dc9 ("mlxsw: spectrum_router: Maintain CRIF for fallback loopback RIF")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

> ---
> Applies to net.
> 
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

[...]

Thanks,
Olek