netdev - Re: [net PATCH V2] octeontx2-af: Fix issues with NPC field hash extract

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23a2d0a8-3a68-f649-51a2-3ebf401b59c4@intel.com>
Date: Mon, 3 Jul 2023 17:48:23 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Suman Ghosh <sumang@...vell.com>
CC: <sgoutham@...vell.com>, <gakula@...vell.com>, <sbhatta@...vell.com>,
	<hkelam@...vell.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [net PATCH V2] octeontx2-af: Fix issues with NPC field hash
 extract

From: Suman Ghosh <sumang@...vell.com>
Date: Mon, 3 Jul 2023 17:50:40 +0530

> 1. Allow field hash configuration for both source and destination IPv6.
> 2. Configure hardware parser based on hash extract feature enable flag
>    for IPv6.
> 3. Fix IPv6 endianness issue while updating the source/destination IP
>    address via ntuple rule.
> 4. Update hash extraction mbox message.
> 5. Enable hash extraction based on the MKEX profile

That's a lot. Can't this patch be split? For example, one commit per
list item? I don't think it's atomic.

> 
> Fixes: 56d9f5fd2246 ("octeontx2-af: Use hashed field in MCAM key")
> Signed-off-by: Suman Ghosh <sumang@...vell.com>
[...]

Thanks,
Olek