netdev - Re: [PATCH net 1/2] ice: Fix max_rate check while configuring TX rate limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230706075042.GQ6455@unreal>
Date: Thu, 6 Jul 2023 10:50:42 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>,
	Bharathi Sreenivas <bharathi.sreenivas@...el.com>
Subject: Re: [PATCH net 1/2] ice: Fix max_rate check while configuring TX
 rate limits

On Wed, Jul 05, 2023 at 01:13:45PM -0700, Tony Nguyen wrote:
> From: Sridhar Samudrala <sridhar.samudrala@...el.com>
> 
> Remove incorrect check in ice_validate_mqprio_opt() that limits
> filter configuration when sum of max_rates of all TCs exceeds
> the link speed. The max rate of each TC is unrelated to value
> used by other TCs and is valid as long as it is less than link
> speed.
> 
> Fixes: fbc7b27af0f9 ("ice: enable ndo_setup_tc support for mqprio_qdisc")
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>
> Tested-by: Bharathi Sreenivas <bharathi.sreenivas@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>