netdev - Re: [PATCH net 2/2] ice: Fix tx queue rate limit when TCs are configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230706075050.GR6455@unreal>
Date: Thu, 6 Jul 2023 10:50:50 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>,
	Bharathi Sreenivas <bharathi.sreenivas@...el.com>
Subject: Re: [PATCH net 2/2] ice: Fix tx queue rate limit when TCs are
 configured

On Wed, Jul 05, 2023 at 01:13:46PM -0700, Tony Nguyen wrote:
> From: Sridhar Samudrala <sridhar.samudrala@...el.com>
> 
> Configuring tx_maxrate via sysfs interface
> /sys/class/net/eth0/queues/tx-1/tx_maxrate was not working when
> TCs are configured because always main VSI was being used. Fix by
> using correct VSI in ice_set_tx_maxrate when TCs are configured.
> 
> Fixes: 1ddef455f4a8 ("ice: Add NDO callback to set the maximum per-queue bitrate")
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>
> Tested-by: Bharathi Sreenivas <bharathi.sreenivas@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c   |  7 +++++++
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 22 ++++++++++-----------
>  drivers/net/ethernet/intel/ice/ice_tc_lib.h |  1 +
>  3 files changed, 19 insertions(+), 11 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>