netdev - 回复: [PATCH v1] net:tipc:Remove repeated initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 7 Jul 2023 01:21:52 +0000
From: 王明-软件底层技术部 <machel@...o.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Jon Maloy <jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tipc-discussion@...ts.sourceforge.net"
	<tipc-discussion@...ts.sourceforge.net>, LKML <linux-kernel@...r.kernel.org>,
	opensource.kernel <opensource.kernel@...o.com>
Subject:
 回复: [PATCH v1] net:tipc:Remove repeated initialization

Hi Jakub Kicinski
: )
I understand, but I am confused about whether my modification is wrong?

-----邮件原件-----
发件人: Jakub Kicinski <kuba@...nel.org> 
发送时间: 2023年7月6日 23:47
收件人: 王明-软件底层技术部 <machel@...o.com>
抄送: Jon Maloy <jmaloy@...hat.com>; Ying Xue <ying.xue@...driver.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net; linux-kernel@...r.kernel.org; opensource.kernel <opensource.kernel@...o.com>
主题: Re: [PATCH v1] net:tipc:Remove repeated initialization

[Some people who received this message don't often get email from kuba@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Thu,  6 Jul 2023 21:42:09 +0800 Wang Ming wrote:
> The original code initializes 'tmp' twice, which causes duplicate 
> initialization issue.
> To fix this, we remove the second initialization of 'tmp' and use 
> 'parent' directly forsubsequent operations.
>
> Signed-off-by: Wang Ming <machel@...o.com>

Please stop sending the "remove repeated initialization" patches to networking, thanks.