netdev - 回复: [PATCH v1] net:tipc:Remove repeated initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 7 Jul 2023 01:24:56 +0000
From: 王明-软件底层技术部 <machel@...o.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC: Jon Maloy <jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tipc-discussion@...ts.sourceforge.net"
	<tipc-discussion@...ts.sourceforge.net>, LKML <linux-kernel@...r.kernel.org>,
	opensource.kernel <opensource.kernel@...o.com>, Jakub Kicinski
	<kuba@...nel.org>
Subject:
 回复: [PATCH v1] net:tipc:Remove repeated initialization

Hi CJ
: )
So what you're saying is there's no repeat initialization problem here.

-----邮件原件-----
发件人: Christophe JAILLET <christophe.jaillet@...adoo.fr> 
发送时间: 2023年7月7日 1:14
收件人: 王明-软件底层技术部 <machel@...o.com>
抄送: Jon Maloy <jmaloy@...hat.com>; Ying Xue <ying.xue@...driver.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net; linux-kernel@...r.kernel.org; opensource.kernel <opensource.kernel@...o.com>; Jakub Kicinski <kuba@...nel.org>
主题: Re: [PATCH v1] net:tipc:Remove repeated initialization

[你通常不会收到来自 christophe.jaillet@...adoo.fr 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]

Le 06/07/2023 à 17:47, Jakub Kicinski a écrit :
> On Thu,  6 Jul 2023 21:42:09 +0800 Wang Ming wrote:
>> The original code initializes 'tmp' twice, which causes duplicate 
>> initialization issue.
>> To fix this, we remove the second initialization of 'tmp' and use 
>> 'parent' directly forsubsequent operations.
>>
>> Signed-off-by: Wang Ming <machel@...o.com>
>
> Please stop sending the "remove repeated initialization" patches to 
> networking, thanks.
>
>

The patch also looks just bogus, as 'parent' is now always NULL when:
    rb_link_node(&m->tree_node, parent, n);

is called after the while loop.

CJ