netdev - Re: [PATCH 1/1] net: gro: fix misuse of CB in udp socket lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230710145403.GA22009@debian>
Date: Mon, 10 Jul 2023 16:54:05 +0200
From: Richard Gobert <richardbgobert@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	willemdebruijn.kernel@...il.com, dsahern@...nel.org,
	tom@...bertland.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, gal@...dia.com
Subject: Re: [PATCH 1/1] net: gro: fix misuse of CB in udp socket lookup

Thanks, I will send a v2 with the fixes.

> ipv6_rcv() inits
> 
> IP6CB(skb)->iif = skb_dst(skb) ?
> ip6_dst_idev(skb_dst(skb))->dev->ifindex : dev->ifindex;
> 
> You chose to always use skb->dev->ifindex instead ?
> 
> You might add a comment why it is okay.

It looks like this assignment ("ip6_dst_idev(skb_dst(skb))->dev->ifindex")
is relevant only in case of sending traffic on loopback.
It does not seem relevant in GRO stack.
That is why I chose to use only the `skb->dev->ifindex` part.
Do you think that's correct?