netdev - Re: [PATCH net-next v2 3/4] net: phy: c45: add support for 1000BASE-T1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKx0sjNPWu3s4JdI@francesco-nb.int.toradex.com>
Date: Mon, 10 Jul 2023 23:14:26 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Stefan Eichenberger <eichest@...il.com>
Cc: netdev@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
	linux@...linux.org.uk, francesco.dolcini@...adex.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com
Subject: Re: [PATCH net-next v2 3/4] net: phy: c45: add support for
 1000BASE-T1

On Mon, Jul 10, 2023 at 10:58:59PM +0200, Stefan Eichenberger wrote:
> Add support for 1000BASE-T1 to the forced link setup.
> 
> Signed-off-by: Stefan Eichenberger <eichest@...il.com>
> ---
>  drivers/net/phy/phy-c45.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
> index 93ed072233779..ec1232066b914 100644
> --- a/drivers/net/phy/phy-c45.c
> +++ b/drivers/net/phy/phy-c45.c
...

> @@ -176,6 +176,12 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev)
>  		ret = genphy_c45_pma_baset1_setup_master_slave(phydev);
>  		if (ret < 0)
>  			return ret;
> +
> +		bt1_ctrl = 0;
> +		if (phydev->speed == SPEED_1000)
> +			bt1_ctrl = MDIO_PMA_PMD_BT1_CTRL_STRAP_B1000;
> +		phy_modify_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_PMD_BT1_CTRL,
> +			       MDIO_PMA_PMD_BT1_CTRL_STRAP, bt1_ctrl);

check the return value here?