netdev - Re: [PATCH net-next v3] net: txgbe: change LAN reset mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 12 Jul 2023 14:28:43 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v3] net: txgbe: change LAN reset mode

On Tue, Jul 11, 2023 at 02:26:23PM +0800, Jiawen Wu wrote:
> The old way to do LAN reset is sending reset command to firmware. Once
> firmware performs reset, it reconfigures what it needs.
> 
> In the new firmware versions, veto bit is introduced for NCSI/LLDP to
> block PHY domain in LAN reset. At this point, writing register of LAN
> reset directly makes the same effect as the old way. And it does not
> reset MNG domain, so that veto bit does not change.
> 
> And this change is compatible with old firmware versions, since veto
> bit was never used.

Can I confirm that:

1. Old firmware works both with and without this patch;
2. New firmware works with this patch but not without it?

> Fixes: b08012568ebb ("net: txgbe: Reset hardware")
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>

This feels more like an enhancement, to support new firmware,
than a fix: old firmware works fine (wrt to this feature).

I suggest dropping drop the Fixes tag.

...