netdev - Re: [PATCH] net: bonding: Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96729cb7-a06c-dc1f-6f91-22314e72b7ed@web.de>
Date: Fri, 14 Jul 2023 10:23:44 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Wang Ming <machel@...o.com>, opensource.kernel@...o.com,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Andy Gospodarek <andy@...yhouse.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Guangbin Huang <huangguangbin2@...wei.com>, Jakub Kicinski
 <kuba@...nel.org>, Jay Vosburgh <j.vosburgh@...il.com>,
 Paolo Abeni <pabeni@...hat.com>, Yufeng Mo <moyufeng@...wei.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Minjie Du <duminjie@...o.com>,
 Jay Vosburgh <jay.vosburgh@...onical.com>
Subject: Re: [PATCH] net: bonding: Fix error checking for debugfs_create_dir()

> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in bond_create_debugfs() was forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel@...o.com>
>
> Fixes: 52333512701b ("net: bonding: remove unnecessary braces")

Would any other tag ordering be preferred?

How do you think about to use a subject like “[PATCH v2] net: bonding:
Fix an error check in bond_create_debugfs()”?

Regards,
Markus