netdev - 回复: [PATCH net v1] net:bonding:Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SG2PR06MB37437E7EEC1C5E104A432D0DBD34A@SG2PR06MB3743.apcprd06.prod.outlook.com>
Date: Fri, 14 Jul 2023 01:56:44 +0000
From: 王明-软件底层技术部 <machel@...o.com>
To: Jay Vosburgh <jay.vosburgh@...onical.com>
CC: Andy Gospodarek <andy@...yhouse.net>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Yufeng Mo
	<moyufeng@...wei.com>, Guangbin Huang <huangguangbin2@...wei.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	opensource.kernel <opensource.kernel@...o.com>
Subject:
 回复: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

I think we can remove the check on it, don't you agree? Maybe I should resubmit a new patch
Regards
Wang Ming

-----邮件原件-----
发件人: Jay Vosburgh <jay.vosburgh@...onical.com> 
发送时间: 2023年7月13日 23:49
收件人: 王明-软件底层技术部 <machel@...o.com>
抄送: Andy Gospodarek <andy@...yhouse.net>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Yufeng Mo <moyufeng@...wei.com>; Guangbin Huang <huangguangbin2@...wei.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; opensource.kernel <opensource.kernel@...o.com>
主题: Re: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

[????????? jay.vosburgh@...onical.com ????????? https://aka.ms/LearnAboutSenderIdentification?????????????]

Wang Ming <machel@...o.com> wrote:

>The debugfs_create_dir() function returns error pointers, it never 
>returns NULL. Most incorrect error checks were fixed, but the one in 
>bond_create_debugfs() was forgotten.
>
>Fix the remaining error check.
>
>Signed-off-by: Wang Ming <machel@...o.com>

        Seems fine to me; note that almost nobody uses this as bonding debugfs is hidden behind !CONFIG_NET_NS.

Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>

        -J

>Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c 
>b/drivers/net/bonding/bond_debugfs.c
>index 594094526648..d4a82f276e87 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -88,7 +88,7 @@ void bond_create_debugfs(void)  {
>       bonding_debug_root = debugfs_create_dir("bonding", NULL);
>
>-      if (!bonding_debug_root)
>+      if (IS_ERR(bonding_debug_root))
>               pr_warn("Warning: Cannot create bonding directory in 
> debugfs\n"); }
>
>--
>2.25.1
>
>