netdev - RE: TC: selftests: current timeout (45s) is too low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jul 2023 15:15:11 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Matthieu Baerts' <matthieu.baerts@...sares.net>, Pedro Tammela
	<pctammela@...atatu.com>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
	<xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>
CC: netdev <netdev@...r.kernel.org>, Anders Roxell <anders.roxell@...aro.org>,
	Davide Caratti <dcaratti@...hat.com>
Subject: RE: TC: selftests: current timeout (45s) is too low

From: Matthieu Baerts
> Sent: 12 July 2023 15:43
> 
> Hi Pedro,
> 
> On 12/07/2023 15:43, Pedro Tammela wrote:
> > I have been involved in tdc for a while now, here are my comments.
> 
> Thank you for your reply!
> 
> > On 12/07/2023 06:47, Matthieu Baerts wrote:
> >> Hi Jamal, Cong, Jiri,
> >>
> >> When looking for something else [1] in LKFT reports [2], I noticed that
> >> the TC selftest ended with a timeout error:
> >>
> >>    not ok 1 selftests: tc-testing: tdc.sh # TIMEOUT 45 seconds
...
> >> I'm sending this email instead of a patch because I don't know which
> >> value makes sense. I guess you know how long the tests can take in a
> >> (very) slow environment and you might want to avoid this timeout error.
> >
> > I believe a timeout between 5-10 to minutes should cover the entire suite
> 
> Thank you for your feedback.
> If we want to be on the safe side, I guess it is better to put 10
> minutes or even 15, no?

Is it possible to use the time taken for an initial test
to scale the timeout for all the tests?

Then you could have a 45second timeout on a fast system and
a much longer timeout on a slow one.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)