netdev - Re: TC: selftests: current timeout (45s) is too low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jul 2023 10:19:52 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: David Laight <David.Laight@...LAB.COM>,
 Pedro Tammela <pctammela@...atatu.com>, Jamal Hadi Salim <jhs@...atatu.com>,
 Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>
Cc: netdev <netdev@...r.kernel.org>, Anders Roxell
 <anders.roxell@...aro.org>, Davide Caratti <dcaratti@...hat.com>
Subject: Re: TC: selftests: current timeout (45s) is too low

Hi David,

On 14/07/2023 17:15, David Laight wrote:
> From: Matthieu Baerts
>> Sent: 12 July 2023 15:43
>>
>> Hi Pedro,
>>
>> On 12/07/2023 15:43, Pedro Tammela wrote:
>>> I have been involved in tdc for a while now, here are my comments.
>>
>> Thank you for your reply!
>>
>>> On 12/07/2023 06:47, Matthieu Baerts wrote:
>>>> Hi Jamal, Cong, Jiri,
>>>>
>>>> When looking for something else [1] in LKFT reports [2], I noticed that
>>>> the TC selftest ended with a timeout error:
>>>>
>>>>    not ok 1 selftests: tc-testing: tdc.sh # TIMEOUT 45 seconds
> ...
>>>> I'm sending this email instead of a patch because I don't know which
>>>> value makes sense. I guess you know how long the tests can take in a
>>>> (very) slow environment and you might want to avoid this timeout error.
>>>
>>> I believe a timeout between 5-10 to minutes should cover the entire suite
>>
>> Thank you for your feedback.
>> If we want to be on the safe side, I guess it is better to put 10
>> minutes or even 15, no?
> 
> Is it possible to use the time taken for an initial test
> to scale the timeout for all the tests?
> 
> Then you could have a 45second timeout on a fast system and
> a much longer timeout on a slow one.

For the selftests global timeout, that would be great but with the
current architecture, it is not possible to do that because the value of
this global timeout is used when starting the different selftests, e.g.

  /usr/bin/timeout --foreground 45 ./tdc.sh

For the per-test timeout used in TC test environment -- currently at 24
seconds -- I guess it could be adapted like that but that's a different
topic.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net