netdev - Re: [PATCH] net: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 18 Jul 2023 11:27:10 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Alex Elder <elder@...e.org>, Rob Herring <robh@...nel.org>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>,  Alex Elder <elder@...nel.org>
Cc: devicetree@...r.kernel.org, linux-can@...r.kernel.org, 
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev, 
 linux-mediatek@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, 
 linux-renesas-soc@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com, 
 linux-amlogic@...ts.infradead.org, linux-oxnas@...ups.io, 
 linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org, 
 linux-wpan@...r.kernel.org, ath10k@...ts.infradead.org, 
 linux-wireless@...r.kernel.org, ath11k@...ts.infradead.org, 
 wcn36xx@...ts.infradead.org
Subject: Re: [PATCH] net: Explicitly include correct DT includes

Hi,

On Sat, 2023-07-15 at 10:11 -0500, Alex Elder wrote:
> On 7/14/23 12:48 PM, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> > 
> > Signed-off-by: Rob Herring <robh@...nel.org>
> 
> (I significantly reduced the addressee list to permit the message
> to be sent.)
> 
> For "drivers/net/ipa/ipa_main.c":
> 
> Acked-by: Alex Elder <elder@...aro.org>

The patch does not apply cleanly to net-next. Rob, could you please re-
spin it? While at that, have you considered splitting it in a few
smaller patches (e.g. can, dsa, freescale, ibm, marvel, mediatek,
stmmicro,  sun, ti, xilinx, wireless, remaining)?

Thanks!

Paolo