netdev - Re: [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230718093428.ofld4ywhwbpmnw5w@mercury.elektranox.org>
Date: Tue, 18 Jul 2023 11:34:28 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Eugen Hristev <eugen.hristev@...labora.com>
Cc: linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	netdev@...r.kernel.org, david.wu@...k-chips.com, heiko@...ech.de,
	krzysztof.kozlowski+dt@...aro.org, kernel@...labora.com
Subject: Re: [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input'
 for clock_in_out

Hi,

On Tue, Jul 18, 2023 at 12:09:14PM +0300, Eugen Hristev wrote:
> 'clock_in_out' property is optional, and it can be one of two enums.
> The binding does not specify what is the behavior when the property is
> missing altogether.
> Hence, add a default value that the driver can use.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

>  Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 176ea5f90251..bb943c96c196 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -80,6 +80,7 @@ properties:
>        "output" means GMAC provides the reference clock.
>      $ref: /schemas/types.yaml#/definitions/string
>      enum: [input, output]
> +    default: input
>  
>    rockchip,grf:
>      description: The phandle of the syscon node for the general register file.
> -- 
> 2.34.1
> 
> 
> -- 
> To unsubscribe, send mail to kernel-unsubscribe@...ts.collabora.co.uk.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)