netdev - Re: [PATCH net v4] bonding: Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jul 2023 12:20:01 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: 王明-软件底层技术部 <machel@...o.com>, Jay Vosburgh
 <j.vosburgh@...il.com>, Andy Gospodarek <andy@...yhouse.net>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Taku Izumi <izumi.taku@...fujitsu.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "opensource.kernel" <opensource.kernel@...o.com>, 
	"ttoukan.linux@...il.com"
	 <ttoukan.linux@...il.com>, "jay.vosburgh@...onical.com"
	 <jay.vosburgh@...onical.com>
Subject: Re: [PATCH net v4] bonding: Fix error checking for
 debugfs_create_dir()

On Wed, 2023-07-19 at 02:10 +0000, 王明-软件底层技术部 wrote:
> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in bond_create_debugfs() was forgotten.
> 
> Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding driver")
> Signed-off-by: Wang Ming <machel@...o.com>
> ---
>  drivers/net/bonding/bond_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
> index 594094526648..d4a82f276e87 100644
> --- a/drivers/net/bonding/bond_debugfs.c
> +++ b/drivers/net/bonding/bond_debugfs.c
> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
>  {
>  	bonding_debug_root = debugfs_create_dir("bonding", NULL);
>  
> -	if (!bonding_debug_root)
> +	if (IS_ERR(bonding_debug_root))
>  		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>  }
>  

Does not apply cleanly to -net. To be more accurate, the patch is
base64 encoded and git is quite unhappy to decode it.

Possibly your mail server is doing something funny in between?!?

Please solve the above before reposting.

/P