netdev - Re: [PATCH net v4] bonding: Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25152.1689877346@famine>
Date: Thu, 20 Jul 2023 11:22:26 -0700
From: Jay Vosburgh <jay.vosburgh@...onical.com>
To: Paolo Abeni <pabeni@...hat.com>
cc: =?UTF-8?Q?=E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5=BA=95=E5=B1=82?=    =?UTF-8?Q?=E6=8A=80=E6=9C=AF=E9=83=A8?= <machel@...o.com>,
    Andy Gospodarek <andy@...yhouse.net>,
    "David S.
 Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
    Taku Izumi <izumi.taku@...fujitsu.com>,
    "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
    "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
    "opensource.kernel" <opensource.kernel@...o.com>,
    "ttoukan.linux@...il.com" <ttoukan.linux@...il.com>
Subject: Re: [PATCH net v4] bonding: Fix error checking for debugfs_create_dir()

Paolo Abeni <pabeni@...hat.com> wrote:

>On Wed, 2023-07-19 at 02:10 +0000, 王明-软件底层技术部 wrote:
>> The debugfs_create_dir() function returns error pointers,
>> it never returns NULL. Most incorrect error checks were fixed,
>> but the one in bond_create_debugfs() was forgotten.
>> 
>> Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding driver")
>> Signed-off-by: Wang Ming <machel@...o.com>
>> ---
>>  drivers/net/bonding/bond_debugfs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
>> index 594094526648..d4a82f276e87 100644
>> --- a/drivers/net/bonding/bond_debugfs.c
>> +++ b/drivers/net/bonding/bond_debugfs.c
>> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
>>  {
>>  	bonding_debug_root = debugfs_create_dir("bonding", NULL);
>>  
>> -	if (!bonding_debug_root)
>> +	if (IS_ERR(bonding_debug_root))
>>  		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>>  }
>>  
>
>Does not apply cleanly to -net. To be more accurate, the patch is
>base64 encoded and git is quite unhappy to decode it.
>
>Possibly your mail server is doing something funny in between?!?
>
>Please solve the above before reposting.

	It appears to have trailing carriage returns on every line after
base64 decoding, i.e.,

$ git am /tmp/test.patch
[ this fails ]
$ git am --show-current-patch=diff > /tmp/patch2
$ cat -v /tmp/patch2 
---^M
 drivers/net/bonding/bond_debugfs.c | 2 +-^M
 1 file changed, 1 insertion(+), 1 deletion(-)^M
^M
diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c^M
index 594094526648..d4a82f276e87 100644^M
--- a/drivers/net/bonding/bond_debugfs.c^M
+++ b/drivers/net/bonding/bond_debugfs.c^M
@@ -88,7 +88,7 @@ void bond_create_debugfs(void)^M
[...]

	-J

---
	-Jay Vosburgh, jay.vosburgh@...onical.com