netdev - Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a8e7c20-0556-6466-89a1-5cbe228ae9d3@amd.com>
Date: Mon, 24 Jul 2023 14:39:51 -0700
From: Brett Creeley <bcreeley@....com>
To: Jason Gunthorpe <jgg@...dia.com>
Cc: "Tian, Kevin" <kevin.tian@...el.com>,
 Brett Creeley <brett.creeley@....com>,
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
 "yishaih@...dia.com" <yishaih@...dia.com>,
 "shameerali.kolothum.thodi@...wei.com"
 <shameerali.kolothum.thodi@...wei.com>,
 "shannon.nelson@....com" <shannon.nelson@....com>
Subject: Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support

On 7/24/2023 5:58 AM, Jason Gunthorpe wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Sat, Jul 22, 2023 at 12:17:34AM -0700, Brett Creeley wrote:
>>> I wonder whether the logic about migration file can be generalized.
>>> It's not very maintainable to have every migration driver implementing
>>> their own code for similar functions.
>>>
>>> Did I overlook any device specific setup required here?
>>
>> There isn't device specific setup, but the other drivers were different
>> enough that it wasn't a straight forward task. I think it might be possible
>> to refactor the drivers to some common functionality here, but IMO this
>> seems like a task that can be further explored once this series is merged.
> 
> You keep saying that but, things seem to be getting worse. There are
> alot of migration drivers being posted right now with alot of copy and
> paste from mlx5.

I understand and agree with what you guys are saying. However, I was 
also asked to simplify this code for our use case in v9, which I have 
done. I’d like to get this finalized so that I have a chance to get to 
the next step and maybe work with all involved to define what can be 
commonized and how to get there.

Brett

> 
> Jason