netdev - Re: [PATCH v12 vfio 5/7] vfio/pds: Add support for dirty page tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMAGkcIPnWs/+Y/B@corigine.com>
Date: Tue, 25 Jul 2023 19:29:53 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Brett Creeley <brett.creeley@....com>
Cc: kvm@...r.kernel.org, netdev@...r.kernel.org, alex.williamson@...hat.com,
	jgg@...dia.com, yishaih@...dia.com,
	shameerali.kolothum.thodi@...wei.com, kevin.tian@...el.com,
	shannon.nelson@....com
Subject: Re: [PATCH v12 vfio 5/7] vfio/pds: Add support for dirty page
 tracking

On Wed, Jul 19, 2023 at 03:35:25PM -0700, Brett Creeley wrote:

...

> +static void pds_vfio_dirty_free_bitmaps(struct pds_vfio_dirty *dirty)
> +{
> +	if (dirty->host_seq.bmp)
> +		vfree(dirty->host_seq.bmp);
> +	if (dirty->host_ack.bmp)
> +		vfree(dirty->host_ack.bmp);

Hi Brett,

I don't think there is a need to guard these vfree calls,
as I think they will be no-ops with NULL arguments.

> +
> +	dirty->host_seq.bmp = NULL;
> +	dirty->host_ack.bmp = NULL;
> +}

...