netdev - Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMAHAE9dnMzKzFgW@corigine.com>
Date: Tue, 25 Jul 2023 19:31:44 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Brett Creeley <brett.creeley@....com>
Cc: kvm@...r.kernel.org, netdev@...r.kernel.org, alex.williamson@...hat.com,
	jgg@...dia.com, yishaih@...dia.com,
	shameerali.kolothum.thodi@...wei.com, kevin.tian@...el.com,
	shannon.nelson@....com
Subject: Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support

On Wed, Jul 19, 2023 at 03:35:24PM -0700, Brett Creeley wrote:

...

> diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c

...

> +static int pds_vfio_get_save_file(struct pds_vfio_pci_device *pds_vfio)
> +{
> +	struct device *dev = &pds_vfio->vfio_coredev.pdev->dev;
> +	struct pds_vfio_lm_file *lm_file;
> +	int err;
> +	u64 size;

Hi Brett,

please use reverse xmas tree - longest line to shortest -
for these local variable declarations.

https://github.com/ecree-solarflare/xmastree is your friend here.