netdev - Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91d550a7-0759-664d-c31a-4d2b88a4741b@amd.com>
Date: Tue, 25 Jul 2023 10:58:19 -0700
From: Brett Creeley <bcreeley@....com>
To: Simon Horman <simon.horman@...igine.com>,
 Brett Creeley <brett.creeley@....com>
Cc: kvm@...r.kernel.org, netdev@...r.kernel.org, alex.williamson@...hat.com,
 jgg@...dia.com, yishaih@...dia.com, shameerali.kolothum.thodi@...wei.com,
 kevin.tian@...el.com, shannon.nelson@....com
Subject: Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support



On 7/25/2023 10:31 AM, Simon Horman wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Wed, Jul 19, 2023 at 03:35:24PM -0700, Brett Creeley wrote:
> 
> ...
> 
>> diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c
> 
> ...
> 
>> +static int pds_vfio_get_save_file(struct pds_vfio_pci_device *pds_vfio)
>> +{
>> +     struct device *dev = &pds_vfio->vfio_coredev.pdev->dev;
>> +     struct pds_vfio_lm_file *lm_file;
>> +     int err;
>> +     u64 size;
> 
> Hi Brett,
> 
> please use reverse xmas tree - longest line to shortest -
> for these local variable declarations.
> 
> https://github.com/ecree-solarflare/xmastree is your friend here.

Ah, good catch and thanks for the reference. Will fix on v13.