lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230724151946.04deb72f@kernel.org>
Date: Mon, 24 Jul 2023 15:19:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
Cc: donald.hunter@...il.com, netdev@...r.kernel.org, davem@...emloft.net,
 pabeni@...hat.com, edumazet@...gle.com, simon.horman@...igine.com
Subject: Re: [PATCH net-next v4 2/2] tools: ynl-gen: fix parse multi-attr
 enum attribute

On Mon, 24 Jul 2023 12:25:21 +0200 Arkadiusz Kubalewski wrote:
> @@ -438,7 +438,7 @@ class YnlFamily(SpecFamily):
>              decoded = attr.as_struct(members)
>              for m in members:
>                  if m.enum:
> -                    self._decode_enum(decoded, m)
> +                     decoded[m.name] = self._decode_enum(decoded[m.name], m)

The indentation looks messed up here, otherwise LGTM.
-- 
pw-bot: cr

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ