netdev - RE: [PATCH net-next v4 2/2] tools: ynl-gen: fix parse multi-attr enum attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB46578125CC04E6FAC8A548619B03A@DM6PR11MB4657.namprd11.prod.outlook.com>
Date: Tue, 25 Jul 2023 10:22:25 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "simon.horman@...igine.com"
	<simon.horman@...igine.com>
Subject: RE: [PATCH net-next v4 2/2] tools: ynl-gen: fix parse multi-attr enum
 attribute

>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Tuesday, July 25, 2023 12:20 AM
>
>On Mon, 24 Jul 2023 12:25:21 +0200 Arkadiusz Kubalewski wrote:
>> @@ -438,7 +438,7 @@ class YnlFamily(SpecFamily):
>>              decoded = attr.as_struct(members)
>>              for m in members:
>>                  if m.enum:
>> -                    self._decode_enum(decoded, m)
>> +                     decoded[m.name] =
>self._decode_enum(decoded[m.name], m)
>
>The indentation looks messed up here, otherwise LGTM.

Yes, fixed in v5.

Thank you!
Arkadiusz

>--
>pw-bot: cr