netdev - Re: [PATCH v4 bpf 1/2] bpf: fix skb_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 09:42:28 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yan Zhai <yan@...udflare.com>, bpf@...r.kernel.org,
 kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, kernel-team@...udflare.com
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
 Jordan Griege <jgriege@...udflare.com>, Jakub Sitnicki
 <jakub@...udflare.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 bpf 1/2] bpf: fix skb_do_redirect return values

> skb_do_redirect returns various of values: error code (negative),
> 0 (success), and some positive status code, e.g. NET_XMIT_CN,

How do you think about to use a wording variant (like the following)?

  skb_do_redirect() returns different value kinds so far:

Can it be nicer to use a multi-line enumeration here?

> NET_RX_DROP. Commit 3a0af8fd61f9 ("bpf: BPF for lightweight tunnel

I suggest to start this sentence on a separate line.
Can the commit specification fit into the same line then?

…
> https://gist.github.com/zhaiyan920/8fbac245b261fe316a7ef04c9b1eba48

Can it help to mention here that you would like to refer to
a complete KASAN report (which contains 89 text lines then)?

> Convert positive statuses from skb_do_redirect eliminates this issue.

Would you like to avoid another wording weakness in this sentence?
How do you think about to use the following wording variant?

  Thus convert positive status values from the execution of
  the function “skb_do_redirect” into special error codes.

…
> Suggested-by: Markus Elfring
…

I dare to point review concerns out for various software components.
But I did not get the impression that I suggested the patch idea.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n584

Thus I find this tag inappropriate here.
Would any information become more relevant for related version descriptions?

Regards,
Markus