netdev - RE: [PATCH net-next v2 2/2] r8152: set bp in bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 09:50:18 +0000
From: Hayes Wang <hayeswang@...ltek.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>
Subject: RE: [PATCH net-next v2 2/2] r8152: set bp in bulk

Andrew Lunn <andrew@...n.ch>
> Sent: Wednesday, July 26, 2023 4:39 PM
[...]
> >       /* wait 3 ms to make sure the firmware is stopped */
> >       usleep_range(3000, 6000);
> 
> How much time do you save compared to this 3ms - 6ms sleep?

I think it depends on the CPU and the USB host controller.
Take the PC produced this year for example, I think it saves less than 3ms normally.
However, I think saving the number of control transfer is better for both software and hardware.

Best Regards,
Hayes