netdev - Re: [PATCH net-next 1/2] net: ngbe: add ncsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230725194456.7832c02d@kernel.org>
Date: Tue, 25 Jul 2023 19:44:56 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for
 wangxun nics

On Wed, 26 Jul 2023 09:59:15 +0800 mengyuanlou@...-swift.com wrote:
> > 2023年7月26日 07:22，Jakub Kicinski <kuba@...nel.org> 写道：
> > On Mon, 24 Jul 2023 17:24:58 +0800 Mengyuan Lou wrote:  
> >> + netdev->ncsi_enabled = wx->ncsi_hw_supported;  
> > 
> > I don't think that enabled and supported are the same thing.
> > If server has multiple NICs or a NIC with multiple ports and
> > BMC only uses one, or even none, we shouldn't keep the PHY up.
> > By that logic 99% of server NICs should report NCSI as enabled.
> 
> For a NIC with multiple ports, BMC switch connection for port0 to port1 online,
> Drivers can not know port1 should keep up, if do not set ncsi_enabled before. 

I'm not crystal clear on what you're saying. But BMC sends a enable
command to the NIC to enable a channel (or some such). This is all
handled by FW. The FW can tell the host that the NCSI is now active
on port1 and not port0.