netdev - RE: [PATCH v2 00/10] stmmac: Add Loongson platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <DM4PR12MB50880AA9F0C93F86B0A7A308D301A@DM4PR12MB5088.namprd12.prod.outlook.com>
Date: Thu, 27 Jul 2023 09:02:12 +0000
From: Jose Abreu <Jose.Abreu@...opsys.com>
To: Feiyang Chen <chenfeiyang@...ngson.cn>, "andrew@...n.ch" <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "peppe.cavallaro@...com"
	<peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com"
	<alexandre.torgue@...s.st.com>,
        "chenhuacai@...ngson.cn"
	<chenhuacai@...ngson.cn>
CC: "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "dongbiao@...ngson.cn" <dongbiao@...ngson.cn>,
        "loongson-kernel@...ts.loongnix.cn" <loongson-kernel@...ts.loongnix.cn>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
        "chris.chenfeiyang@...il.com" <chris.chenfeiyang@...il.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Subject: RE: [PATCH v2 00/10] stmmac: Add Loongson platform support

From: Feiyang Chen <chenfeiyang@...ngson.cn>
Date: Thu, Jul 27, 2023 at 08:15:44

> Extend stmmac functions and macros for Loongson DWMAC.
> Add LS7A support for dwmac_loongson.
> 
> Feiyang Chen (10):
>   net: stmmac: Pass stmmac_priv and chan in some callbacks
>   net: stmmac: dwmac1000: Allow platforms to choose some register
>     offsets
>   net: stmmac: dwmac1000: Add multi-channel support
>   net: stmmac: dwmac1000: Add 64-bit DMA support
>   net: stmmac: dwmac1000: Add Loongson register definitions
>   net: stmmac: Add Loongson HWIF entry
>   net: stmmac: dwmac-loongson: Add LS7A support
>   net: stmmac: dwmac-loongson: Disable flow control for GMAC
>   net: stmmac: dwmac-loongson: Add 64-bit DMA and multi-vector support
>   net: stmmac: dwmac-loongson: Add GNET support

I took a quick look at your patches and I'm thinking whether this is the correct way to go.
You are mixing up the stmmac generic layer by adding the Loongson HWIF entry.
The whole idea of HWIF was to have it independent of vendor specific logic.

Can you devise another alternative without mixing up the HWIF?

Thanks,
Jose