netdev - Re: [PATCH v2 03/10] net: stmmac: dwmac1000: Add multi-channel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51338bc8-92b0-4aab-92f8-1e5d178b05d7@lunn.ch>
Date: Thu, 27 Jul 2023 11:01:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Feiyang Chen <chenfeiyang@...ngson.cn>
Cc: hkallweit1@...il.com, peppe.cavallaro@...com,
	alexandre.torgue@...s.st.com, joabreu@...opsys.com,
	chenhuacai@...ngson.cn, linux@...linux.org.uk, dongbiao@...ngson.cn,
	loongson-kernel@...ts.loongnix.cn, netdev@...r.kernel.org,
	loongarch@...ts.linux.dev, chris.chenfeiyang@...il.com
Subject: Re: [PATCH v2 03/10] net: stmmac: dwmac1000: Add multi-channel
 support

On Thu, Jul 27, 2023 at 03:15:46PM +0800, Feiyang Chen wrote:
> Some platforms have dwmac1000 implementations that support multi-
> channel. Extend the functions to add multi-channel support.
> 
> +	priv->plat->dwmac_is_loongson = false;

I don't know this driver, so my comments could be wrong...

Is this specific to loongson, or multi-channel? If you look at the
other bool in plat, they are all for features, not machines? Could
this actually be called priv->multi_chan_en ?

     Andrew