netdev - Re: [PATCH v2 02/10] net: stmmac: dwmac1000: Allow platforms to choose some register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b52d461-77e5-493a-a634-4c8a0637a0bc@lunn.ch>
Date: Thu, 27 Jul 2023 11:10:07 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Feiyang Chen <chenfeiyang@...ngson.cn>
Cc: hkallweit1@...il.com, peppe.cavallaro@...com,
	alexandre.torgue@...s.st.com, joabreu@...opsys.com,
	chenhuacai@...ngson.cn, linux@...linux.org.uk, dongbiao@...ngson.cn,
	loongson-kernel@...ts.loongnix.cn, netdev@...r.kernel.org,
	loongarch@...ts.linux.dev, chris.chenfeiyang@...il.com
Subject: Re: [PATCH v2 02/10] net: stmmac: dwmac1000: Allow platforms to
 choose some register offsets

> +#define _REGS			(priv->plat->dwmac_regs)
>  
> -/* Rx watchdog register */
> +/* DMA CRS Control and Status Register Mapping */
> +#define DMA_CHAN_OFFSET		(_REGS->addrs->chan_offset)

It is thought to be bad practice for a macro to access things not
passed to it. Please try to make a cleaner solution.

       Andrew