netdev - Re: [PATCH v2 05/10] net: stmmac: dwmac1000: Add Loongson register definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64ebd141-87ee-4186-9b4d-0705402c9e89@lunn.ch>
Date: Fri, 28 Jul 2023 10:44:23 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Feiyang Chen <chris.chenfeiyang@...il.com>
Cc: Feiyang Chen <chenfeiyang@...ngson.cn>, hkallweit1@...il.com,
	peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
	joabreu@...opsys.com, chenhuacai@...ngson.cn, linux@...linux.org.uk,
	dongbiao@...ngson.cn, loongson-kernel@...ts.loongnix.cn,
	netdev@...r.kernel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH v2 05/10] net: stmmac: dwmac1000: Add Loongson register
 definitions

On Fri, Jul 28, 2023 at 09:45:42AM +0800, Feiyang Chen wrote:
> On Thu, Jul 27, 2023 at 5:13 PM Andrew Lunn <andrew@...n.ch> wrote:
> >
> > >  /* GMAC HW ADDR regs */
> > > -#define GMAC_ADDR_HIGH(reg)  ((reg > 15) ? 0x00000800 + (reg - 16) * 8 : \
> > > +#define GMAC_ADDR_HIGH(reg, x)       ((reg > 15) ? 0x00000800 + (reg - 16) * 8 * (x) : \
> > >                                0x00000040 + (reg * 8))
> >
> > please give x a more descriptive name.
> >
> 
> Hi, Andrew,
> 
> The x is now related to the dwmac_is_loongson flag. I'll try to use
> another method.

Rather than 'dwmac_is_longson', make it represent a feature of the
MAC.

	Andrew