netdev - Re: [PATCH v2 07/10] net: stmmac: dwmac-loongson: Add LS7A support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jul 2023 10:46:12 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Feiyang Chen <chris.chenfeiyang@...il.com>
Cc: Feiyang Chen <chenfeiyang@...ngson.cn>, hkallweit1@...il.com,
	peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
	joabreu@...opsys.com, chenhuacai@...ngson.cn, linux@...linux.org.uk,
	dongbiao@...ngson.cn, loongson-kernel@...ts.loongnix.cn,
	netdev@...r.kernel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH v2 07/10] net: stmmac: dwmac-loongson: Add LS7A support

On Fri, Jul 28, 2023 at 09:59:53AM +0800, Feiyang Chen wrote:
> On Thu, Jul 27, 2023 at 5:18 PM Andrew Lunn <andrew@...n.ch> wrote:
> >
> > > +static void common_default_data(struct pci_dev *pdev,
> > > +                             struct plat_stmmacenet_data *plat)
> > >  {
> > > +     plat->bus_id = (pci_domain_nr(pdev->bus) << 16) | PCI_DEVID(pdev->bus->number, pdev->devfn);
> > > +
> > >       plat->clk_csr = 2;      /* clk_csr_i = 20-35MHz & MDC = clk_csr_i/16 */
> > >       plat->has_gmac = 1;
> > >       plat->force_sf_dma_mode = 1;
> > >
> > >       /* Set default value for multicast hash bins */
> > > -     plat->multicast_filter_bins = HASH_TABLE_SIZE;
> > > +     plat->multicast_filter_bins = 256;
> >
> > HASH_TABLE_SIZE is 64. You appear to be changing it to 256 for
> > everybody, not just your platform. I would expect something like
> > common_default_data() is called first, and then you change values in a
> > loongson specific function.
> >
> 
> Hi, Andrew,
> 
> The common_default_data() here is defined in our platform driver. We
> have tested on our platforms (LS7A and LS2K) and it can be safely
> changed to 256.

Then add a new #define.

     Andrew