netdev - Re: [PATCH bpf-next 1/2] bpf, cpumap: Remove unused cmap field from bpf_cpu_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jul 2023 12:48:00 +0200
From: Jesper Dangaard Brouer <jbrouer@...hat.com>
To: Hou Tao <houtao@...weicloud.com>, bpf@...r.kernel.org
Cc: brouer@...hat.com, netdev@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Björn Töpel <bjorn.topel@...il.com>,
 Martin KaFai Lau <martin.lau@...ux.dev>,
 Alexei Starovoitov <alexei.starovoitov@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Song Liu <song@...nel.org>,
 Hao Luo <haoluo@...gle.com>, Yonghong Song <yonghong.song@...ux.dev>,
 Daniel Borkmann <daniel@...earbox.net>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 houtao1@...wei.com
Subject: Re: [PATCH bpf-next 1/2] bpf, cpumap: Remove unused cmap field from
 bpf_cpu_map_entry

On 28/07/2023 03.49, Hou Tao wrote:
> From: Hou Tao <houtao1@...wei.com>
> 
> Since commit cdfafe98cabe ("xdp: Make cpumap flush_list common for all
> map instances"), cmap is no longer used, so just remove it.
> 
> Signed-off-by: Hou Tao <houtao1@...wei.com>
> ---

LGTM

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

>   kernel/bpf/cpumap.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c
> index 6ae02be7a48e..0a16e30b16ef 100644
> --- a/kernel/bpf/cpumap.c
> +++ b/kernel/bpf/cpumap.c
> @@ -60,8 +60,6 @@ struct bpf_cpu_map_entry {
>   	/* XDP can run multiple RX-ring queues, need __percpu enqueue store */
>   	struct xdp_bulk_queue __percpu *bulkq;
>   
> -	struct bpf_cpu_map *cmap;
> -
>   	/* Queue with potential multi-producers, and single-consumer kthread */
>   	struct ptr_ring *queue;
>   	struct task_struct *kthread;
> @@ -588,7 +586,6 @@ static long cpu_map_update_elem(struct bpf_map *map, void *key, void *value,
>   		rcpu = __cpu_map_entry_alloc(map, &cpumap_value, key_cpu);
>   		if (!rcpu)
>   			return -ENOMEM;
> -		rcpu->cmap = cmap;
>   	}
>   	rcu_read_lock();
>   	__cpu_map_entry_replace(cmap, key_cpu, rcpu);