netdev - Re: [PATCH bpf-next 2/2] bpf, devmap: Remove unused dtab field from bpf_dtab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jul 2023 12:48:54 +0200
From: Jesper Dangaard Brouer <jbrouer@...hat.com>
To: Hou Tao <houtao@...weicloud.com>, bpf@...r.kernel.org
Cc: brouer@...hat.com, netdev@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Björn Töpel <bjorn.topel@...il.com>,
 Martin KaFai Lau <martin.lau@...ux.dev>,
 Alexei Starovoitov <alexei.starovoitov@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Song Liu <song@...nel.org>,
 Hao Luo <haoluo@...gle.com>, Yonghong Song <yonghong.song@...ux.dev>,
 Daniel Borkmann <daniel@...earbox.net>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 houtao1@...wei.com
Subject: Re: [PATCH bpf-next 2/2] bpf, devmap: Remove unused dtab field from
 bpf_dtab_netdev

On 28/07/2023 03.49, Hou Tao wrote:
> From: Hou Tao <houtao1@...wei.com>
> 
> Commit 96360004b862 ("xdp: Make devmap flush_list common for all map
> instances") removes the use of bpf_dtab_netdev::dtab in bq_enqueue(),
> so just remove dtab from bpf_dtab_netdev.
> 
> Signed-off-by: Hou Tao <houtao1@...wei.com>

LGTM

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

> ---
>   kernel/bpf/devmap.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> index 49cc0b5671c6..4d42f6ed6c11 100644
> --- a/kernel/bpf/devmap.c
> +++ b/kernel/bpf/devmap.c
> @@ -65,7 +65,6 @@ struct xdp_dev_bulk_queue {
>   struct bpf_dtab_netdev {
>   	struct net_device *dev; /* must be first member, due to tracepoint */
>   	struct hlist_node index_hlist;
> -	struct bpf_dtab *dtab;
>   	struct bpf_prog *xdp_prog;
>   	struct rcu_head rcu;
>   	unsigned int idx;
> @@ -874,7 +873,6 @@ static struct bpf_dtab_netdev *__dev_map_alloc_node(struct net *net,
>   	}
>   
>   	dev->idx = idx;
> -	dev->dtab = dtab;
>   	if (prog) {
>   		dev->xdp_prog = prog;
>   		dev->val.bpf_prog.id = prog->aux->id;