netdev - Re: [PATCH net-next,v4] bonding: support balance-alb with openvswitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <256143aea3ba443d5496045158e6529923d0d44b.camel@redhat.com>
Date: Tue, 01 Aug 2023 11:56:02 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Mat Kowalski <mko@...hat.com>, "netdev@...r.kernel.org"
	 <netdev@...r.kernel.org>
Cc: Andy Gospodarek <andy@...yhouse.net>, "David S. Miller"
	 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	 <kuba@...nel.org>, Jay Vosburgh <jay.vosburgh@...onical.com>
Subject: Re: [PATCH net-next,v4] bonding: support balance-alb with
 openvswitch

On Mon, 2023-07-31 at 22:21 +0200, Mat Kowalski wrote:
> 
> On 31/07/2023 00:51, Jay Vosburgh wrote:
> > Mat Kowalski <mko@...hat.com> wrote:
> > 
> > > Commit d5410ac7b0ba ("net:bonding:support balance-alb interface with
> > > vlan to bridge") introduced a support for balance-alb mode for
> > > interfaces connected to the linux bridge by fixing missing matching of
> > > MAC entry in FDB. In our testing we discovered that it still does not
> > > work when the bond is connected to the OVS bridge as show in diagram
> > > below:
> > > 
> > > eth1(mac:eth1_mac)--bond0(balance-alb,mac:eth0_mac)--eth0(mac:eth0_mac)
> > >                         |
> > >                       bond0.150(mac:eth0_mac)
> > >                         |
> > >                       ovs_bridge(ip:bridge_ip,mac:eth0_mac)
> > > 
> > > This patch fixes it by checking not only if the device is a bridge but
> > > also if it is an openvswitch.
> > 
> > 	What changed between v3 and v4?
> > 
> > 	-J
> 
> v4 changes:
> - Fix additional space at the beginning of the line
> 
> v3 changes:
> - Fix tab chars converted to spaces
> 
> v2 changes:
> - Fix line wrapping

Note that you should wait at least 24h before submitting a new version:

https://elixir.bootlin.com/linux/v6.5-rc4/source/Documentation/process/maintainer-netdev.rst#L350

3 new revisions in a raw is really not a good thing.

The used email address and the SoB mismatch. You should fix that either
changing the SoB or adding a suitable From: tag.

Please include the changelog in the next revision, after the SoB tag
and a '---' separator.

Cheers,

Paolo