netdev - Re: [PATCH iwl-net v3 0/2] Enhance the tx-usecs coalesce setting implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMjW7XeEqpoHhQFd@kernel.org>
Date: Tue, 1 Aug 2023 11:57:01 +0200
From: Simon Horman <horms@...nel.org>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>
Cc: intel-wired-lan@...osl.org, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
	naamax.meir@...ux.intel.com, anthony.l.nguyen@...el.com
Subject: Re: [PATCH iwl-net v3 0/2] Enhance the tx-usecs coalesce setting
 implementation

On Tue, Aug 01, 2023 at 09:15:16AM +0800, Muhammad Husaini Zulkifli wrote:
> The current tx-usecs coalesce setting implementation in the driver code is
> improved by this patch series. The implementation of the current driver
> code may have previously been a copy of the legacy code i210.
> 
> Patch 1:
> Allow the user to see the tx-usecs colease setting's current value when
> using the ethtool command. The previous value was 0.
> 
> Patch 2:
> Give the user the ability to modify the tx-usecs colease setting's value.
> Previously, it was restricted to rx-usecs.
> 
> V2 -> V3:
> - Refactor the code, as Simon suggested, to make it more readable.
> 
> V1 -> V2:
> - Split the patch file into two, like Anthony suggested.

Thanks for the refactoring.

Reviewed-by: Simon Horman <horms@...nel.org>