netdev - Re: [RFC PATCH net-next 0/2] selftests/tc-testing: initial steps for parallel tdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMkWaHsVnNOo8xjc@dcaratti.users.ipa.redhat.com>
Date: Tue, 1 Aug 2023 16:27:52 +0200
From: Davide Caratti <dcaratti@...hat.com>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, jhs@...atatu.com,
	xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [RFC PATCH net-next 0/2] selftests/tc-testing: initial steps for
 parallel tdc

On Fri, Jul 28, 2023 at 12:40:57PM -0300, Pedro Tammela wrote:
> As the number of tdc tests is growing, so is our completion wall time.
> One of the ideas to improve this is to run tests in parallel, as they
> are self contained. Even though they will serialize over the rtnl lock,
> we expect it to give a nice boost.
> 
> A first step is to make each test independent of each other by
> localizing its resource usage. Today tdc shares everything, including
> veth / dummy interfaces and netns. In patch 1 we make all of these
> resources unique per test.
> 
> Patch 2 updates the tests to the new model, which also simplified some
> definitions and made them more concise and clearer.

hello, 

tests are ok!  A couple of (minor) items:

- the patched code introduces a dependency for python (must be > 3.8).
  That's ok, but maybe we should put this in clear in the commit message
  of patch 1/2.
- TEQL test passes, but the code doesn't look functional for namespaces:
  maybe we can keep teql test not requiring nsPlugin?

other than this, looks good to me, thanks!

Reviewed-and-tested-by: Davide Caratti <dcaratti@...hat.com>