netdev - Re: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9df397a-41c4-02f6-c3b1-1a7c2cf4ad6d@intel.com>
Date: Wed, 2 Aug 2023 18:00:20 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <ast@...nel.org>, <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
	<hawk@...nel.org>, <amritha.nambiar@...el.com>, <j.vosburgh@...il.com>,
	<andy@...yhouse.net>, <shayagr@...zon.com>, <akiyano@...zon.com>,
	<ioana.ciornei@....com>, <claudiu.manoil@....com>, <vladimir.oltean@....com>,
	<wei.fang@....com>, <shenwei.wang@....com>, <xiaoning.wang@....com>,
	<linux-imx@....com>, <dmichail@...gible.com>, <jeroendb@...gle.com>,
	<pkaligineedi@...gle.com>, <shailend@...gle.com>,
	<jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
	<horatiu.vultur@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
	<kys@...rosoft.com>, <haiyangz@...rosoft.com>, <wei.liu@...nel.org>,
	<decui@...rosoft.com>, <peppe.cavallaro@...com>,
	<alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>,
	<mcoquelin.stm32@...il.com>, <grygorii.strashko@...com>,
	<longli@...rosoft.com>, <sharmaajay@...rosoft.com>, <daniel@...earbox.net>,
	<john.fastabend@...il.com>, <gerhard@...leder-embedded.com>,
	<simon.horman@...igine.com>, <leon@...nel.org>,
	<linux-hyperv@...r.kernel.org>
Subject: Re: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue,  1 Aug 2023 17:32:44 -0700

> Handful of drivers currently expect to get xdp.h by virtue
> of including netdevice.h. This will soon no longer be the case
> so add explicit includes.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: j.vosburgh@...il.com
> CC: andy@...yhouse.net
> CC: shayagr@...zon.com
> CC: akiyano@...zon.com
> CC: ioana.ciornei@....com
> CC: claudiu.manoil@....com
> CC: vladimir.oltean@....com
> CC: wei.fang@....com
> CC: shenwei.wang@....com
> CC: xiaoning.wang@....com
> CC: linux-imx@....com
> CC: dmichail@...gible.com
> CC: jeroendb@...gle.com
> CC: pkaligineedi@...gle.com
> CC: shailend@...gle.com
> CC: jesse.brandeburg@...el.com
> CC: anthony.l.nguyen@...el.com
> CC: horatiu.vultur@...rochip.com
> CC: UNGLinuxDriver@...rochip.com
> CC: kys@...rosoft.com
> CC: haiyangz@...rosoft.com
> CC: wei.liu@...nel.org
> CC: decui@...rosoft.com
> CC: peppe.cavallaro@...com
> CC: alexandre.torgue@...s.st.com
> CC: joabreu@...opsys.com
> CC: mcoquelin.stm32@...il.com
> CC: grygorii.strashko@...com
> CC: longli@...rosoft.com
> CC: sharmaajay@...rosoft.com
> CC: daniel@...earbox.net
> CC: hawk@...nel.org
> CC: john.fastabend@...il.com
> CC: gerhard@...leder-embedded.com
> CC: simon.horman@...igine.com
> CC: leon@...nel.org
> CC: linux-hyperv@...r.kernel.org
> CC: bpf@...r.kernel.org
> ---
>  drivers/net/bonding/bond_main.c                       | 1 +
>  drivers/net/ethernet/amazon/ena/ena_netdev.h          | 1 +
>  drivers/net/ethernet/engleder/tsnep.h                 | 1 +
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h      | 1 +
>  drivers/net/ethernet/freescale/enetc/enetc.h          | 1 +
>  drivers/net/ethernet/freescale/fec.h                  | 1 +
>  drivers/net/ethernet/fungible/funeth/funeth_txrx.h    | 1 +
>  drivers/net/ethernet/google/gve/gve.h                 | 1 +
>  drivers/net/ethernet/intel/igc/igc.h                  | 1 +
>  drivers/net/ethernet/microchip/lan966x/lan966x_main.h | 1 +
>  drivers/net/ethernet/microsoft/mana/mana_en.c         | 1 +
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h          | 1 +
>  drivers/net/ethernet/ti/cpsw_priv.h                   | 1 +
>  drivers/net/hyperv/hyperv_net.h                       | 1 +
>  drivers/net/tap.c                                     | 1 +
>  include/net/mana/mana.h                               | 2 ++
>  16 files changed, 17 insertions(+)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 7a0f25301f7e..2f21cca4fdaf 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -90,6 +90,7 @@
>  #include <net/tls.h>
>  #endif
>  #include <net/ip6_route.h>
> +#include <net/xdp.h>
>  
>  #include "bonding_priv.h"
>  
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h
> index 248b715b4d68..a1134152ecce 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.h
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h
> @@ -15,6 +15,7 @@
>  #include <linux/netdevice.h>
>  #include <linux/skbuff.h>
>  #include <uapi/linux/bpf.h>
> +#include <net/xdp.h>

Alphabetical sorting? :>
(for the entire patch)

>  
>  #include "ena_com.h"
>  #include "ena_eth_com.h"

[...]

Thanks,
Olek