netdev - Re: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58b4f563-5bfc-65ed-c213-ae17724e5a33@engleder-embedded.com>
Date: Wed, 2 Aug 2023 20:06:28 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Jakub Kicinski <kuba@...nel.org>, ast@...nel.org
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, hawk@...nel.org,
 amritha.nambiar@...el.com, aleksander.lobakin@...el.com,
 j.vosburgh@...il.com, andy@...yhouse.net, shayagr@...zon.com,
 akiyano@...zon.com, ioana.ciornei@....com, claudiu.manoil@....com,
 vladimir.oltean@....com, wei.fang@....com, shenwei.wang@....com,
 xiaoning.wang@....com, linux-imx@....com, dmichail@...gible.com,
 jeroendb@...gle.com, pkaligineedi@...gle.com, shailend@...gle.com,
 jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
 horatiu.vultur@...rochip.com, UNGLinuxDriver@...rochip.com,
 kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
 decui@...rosoft.com, peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
 joabreu@...opsys.com, mcoquelin.stm32@...il.com, grygorii.strashko@...com,
 longli@...rosoft.com, sharmaajay@...rosoft.com, daniel@...earbox.net,
 john.fastabend@...il.com, simon.horman@...igine.com, leon@...nel.org,
 linux-hyperv@...r.kernel.org
Subject: Re: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers

On 02.08.23 02:32, Jakub Kicinski wrote:
> Handful of drivers currently expect to get xdp.h by virtue
> of including netdevice.h. This will soon no longer be the case
> so add explicit includes.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

(...)

> diff --git a/drivers/net/ethernet/engleder/tsnep.h b/drivers/net/ethernet/engleder/tsnep.h
> index 11b29f56aaf9..6e14c918e3fb 100644
> --- a/drivers/net/ethernet/engleder/tsnep.h
> +++ b/drivers/net/ethernet/engleder/tsnep.h
> @@ -14,6 +14,7 @@
>   #include <linux/net_tstamp.h>
>   #include <linux/ptp_clock_kernel.h>
>   #include <linux/miscdevice.h>
> +#include <net/xdp.h>

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>